-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix BigQuery case-insensitive mapping when cache is disabled #23698
Fix BigQuery case-insensitive mapping when cache is disabled #23698
Conversation
80e100f
to
650879f
Compare
/test-with-secrets sha=650879fffb6d1df4af43d237a02d36a27fa0246b |
The CI workflow run with tests that require additional secrets has been started: https://github.com/trinodb/trino/actions/runs/11214297178 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Put the PR description in the commit message.
.../test/java/io/trino/plugin/bigquery/TestBigQueryCaseInsensitiveMappingWithCacheDisabled.java
Outdated
Show resolved
Hide resolved
.../test/java/io/trino/plugin/bigquery/TestBigQueryCaseInsensitiveMappingWithCacheDisabled.java
Outdated
Show resolved
Hide resolved
e82cd2e
to
2ac20ed
Compare
When cache is disabled, all values put into cache are not persisted, causing cache-insensitive mapping failing This PR decouples mapping from cache handling
2ac20ed
to
8a37172
Compare
/test-with-secrets sha=8a37172f0d0172c73c30650988d4fb2135dcb54b |
The CI workflow run with tests that require additional secrets has been started: https://github.com/trinodb/trino/actions/runs/11231655980 |
Description
When cache is disabled, all values put into cache are not persisted, causing cache-insensitive mapping failing
This PR decouples mapping from cache handling
Release notes